Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add effectful methods for vitest hooks #3686

Closed
wants to merge 12 commits into from
Closed

Add effectful methods for vitest hooks #3686

wants to merge 12 commits into from

Conversation

leonitousconforti
Copy link
Contributor

@leonitousconforti leonitousconforti commented Sep 25, 2024 •
edited
Loading

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

There are two other hooks, onTestFailed and onTestFinished, that I did not make effect methods

Related

  • Related Issue #
  • Closes #

vinassefranche and others added 7 commits September 25, 2024 07:50
@vinassefranche @tim-smart
feat: add HashMap.HashMap.Entry utility type (#3618)
ad4037e
@KhraksMamtsov @tim-smart
Resource<A, E> and ScopedRed<A> is subtype of Effect. (#3626)
91dab28 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
@ianbollinger @tim-smart
Add isRegExp type guard (#3647)
315fb38
@KhraksMamtsov @tim-smart
Latch implements Effect<void> with .await semantics (#3638)
bc8e6d8 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
@leonitousconforti @tim-smart
Effect.provide(managedRuntime) and ManagedRuntime<R, E> is subtyp…
1419a68 
…e of `Effect<Runtime<R>, E, never>` (#3677)
@tim-smart
fix Unify for RcRef & Deferred (#3678)
267a825
@KhraksMamtsov @tim-smart
Pool is subtype of Effect (#3674)
cde84e8 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
Co-authored-by: Tim <hello@timsmart.co>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 082cee7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/vitest Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@leonitousconforti leonitousconforti marked this pull request as ready for review September 25, 2024 14:34
@github-actions github-actions bot force-pushed the next-minor branch 3 times, most recently from ae69407 to ca19b90 Compare September 28, 2024 16:05
@leonitousconforti
Copy link
Contributor Author

my needs for this are better implemented by #3689

@leonitousconforti leonitousconforti deleted the vitest-use-managed-runtime branch September 30, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leonitousconforti @vinassefranche @KhraksMamtsov @ianbollinger @tim-smart